Laszlo Gaal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 9: Code-Review+1

Thanks for the enhancement, Joe. I especially enjoyed the bash redirection 
artwork :)
Carrying and agreeing with +1 from David; letting some other folks take a look.


--
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 9
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Comment-Date: Wed, 23 Sep 2020 12:12:48 +0000
Gerrit-HasComments: No

Reply via email to