Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16474 )
Change subject: IMPALA-10178 Run-time profile shall report skews ...................................................................... Patch Set 16: (8 comments) http://gerrit.cloudera.org:8080/#/c/16474/16/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/16474/16/be/src/util/runtime-profile-counters.h@414 PS16, Line 414: /// all valid raw values backing this average counter. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16474/16/be/src/util/runtime-profile-counters.h@415 PS16, Line 415: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16474/16/be/src/util/runtime-profile-counters.h@417 PS16, Line 417: /// all valid raw values and the population stddev in the form of: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16474/16/be/src/util/runtime-profile-counters.h@419 PS16, Line 419: /// line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16474/16/be/src/util/stat-util.h File be/src/util/stat-util.h: http://gerrit.cloudera.org:8080/#/c/16474/16/be/src/util/stat-util.h@45 PS16, Line 45: /// Computes the mean and the standard deviation (population) from an array of line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16474/16/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/16474/16/tests/query_test/test_observability.py@801 PS16, Line 801: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/16474/16/tests/query_test/test_observability.py@807 PS16, Line 807: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/16474/16/tests/query_test/test_observability.py@817 PS16, Line 817: flake8: E221 multiple spaces before operator -- To view, visit http://gerrit.cloudera.org:8080/16474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91041f2856eef8293ea78f1721f97469062589a1 Gerrit-Change-Number: 16474 Gerrit-PatchSet: 16 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2020 17:53:46 +0000 Gerrit-HasComments: Yes
