Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16462 )
Change subject: IMPALA-10185 Use bool stats for selectivity calculations. ...................................................................... Patch Set 2: (2 comments) Looks good to me! http://gerrit.cloudera.org:8080/#/c/16462/2/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java File fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java: http://gerrit.cloudera.org:8080/#/c/16462/2/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@255 PS2, Line 255: IS_TRUE_LITERAL There are also ISNOTTRUE and ISNOTFALSE. I wonder if they are normalized into IS_TRUE and IS_FALSE. http://gerrit.cloudera.org:8080/#/c/16462/2/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@261 PS2, Line 261: } else if (numNulls >= 0) { Maybe add a condition to test for ISNULL predicate? -- To view, visit http://gerrit.cloudera.org:8080/16462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95c1c7c915bf6bca13fe006c0531c33988187d12 Gerrit-Change-Number: 16462 Gerrit-PatchSet: 2 Gerrit-Owner: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 24 Sep 2020 14:00:30 +0000 Gerrit-HasComments: Yes
