Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16517 )
Change subject: IMPALA-10196: Remove LlvmCodeGen::CastPtrToLlvmPtr ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16517/2/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/16517/2/be/src/codegen/llvm-codegen-test.cc@193 PS2, Line 193: LlvmCodeGen::NamedVariable("counter", codegen->i64_ptr_type())); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16517/2/be/src/codegen/llvm-codegen-test.cc@217 PS2, Line 217: // 4. Similar to 3, but replace the call with a different inner loop function. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16517/2/testdata/llvm/test-loop.cc File testdata/llvm/test-loop.cc: http://gerrit.cloudera.org:8080/#/c/16517/2/testdata/llvm/test-loop.cc@30 PS2, Line 30: printf("Default, value is %ld.\n", *ptr); line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/16517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I046a06fbf23629a90cc2cca164176a89e557c7c4 Gerrit-Change-Number: 16517 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2020 10:50:47 +0000 Gerrit-HasComments: Yes
