Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16500 )

Change subject: IMPALA-10198: Unify Java code under the $IMPALA_HOME/java 
directory
......................................................................


Patch Set 3:

(2 comments)

I think this approach makes sense. I didn't do a thorough review to try and and 
find other things that might need to be updated, so let me know if it's ready 
for that kind of review or if I should hold off for the further cleanup.

http://gerrit.cloudera.org:8080/#/c/16500/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16500/3//COMMIT_MSG@18
PS3, Line 18: This moves all the Java projects other than fe into
We'll probably have to update some of the wiki pages to reflect this right, e.g 
the ones that say to cd into fe?

https://cwiki.apache.org/confluence/display/IMPALA/How+to+load%2C+run%2C+and+create+new+Impala+tests


http://gerrit.cloudera.org:8080/#/c/16500/3/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/16500/3/buildall.sh@449
PS3, Line 449:       MAKE_TARGETS="notests_all_targets"
Nice cleanup



--
To view, visit http://gerrit.cloudera.org:8080/16500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08773f4f9d7cb269b0491080078d6e6f490d8d7a
Gerrit-Change-Number: 16500
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 30 Sep 2020 06:04:53 +0000
Gerrit-HasComments: Yes

Reply via email to