Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16532 )
Change subject: IMPALA-10202: Enable file handle cache for ABFS files ...................................................................... Patch Set 1: Code-Review+2 This looks good to me. If you haven't already, there are a couple sanity checks I would do: 1. Cache an ABFS file handle and then remove the file and see how it behaves. For an object store, I don't expect any weirdness. If the file is gone, I expect the read calls to eventually fail, then subsequent open calls for that file would fail. 2. Take the cache up to its default max_cached_file_handles limit (20,000) and make sure things are ok. It sounds like you did something like this already. -- To view, visit http://gerrit.cloudera.org:8080/16532 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64f12f832980f4e0207af78368402dd09e370fc3 Gerrit-Change-Number: 16532 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 01 Oct 2020 22:08:01 +0000 Gerrit-HasComments: No
