Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16529 )
Change subject: IMPALA-10172: Support Hive metastore managed locations for databases ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/16529/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16529/4//COMMIT_MSG@14 PS4, Line 14: Impala's output for DESCRIBE DATABASE (EXTENDED) nit: could you provide examples of the new output? http://gerrit.cloudera.org:8080/#/c/16529/4//COMMIT_MSG@16 PS4, Line 16: braking nit: breaking http://gerrit.cloudera.org:8080/#/c/16529/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/16529/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1942 PS4, Line 1942: AnalyzesOk("create database new_db managedlocation " + : "'/test-warehouse/new_db'"); nit: fits single line http://gerrit.cloudera.org:8080/#/c/16529/4/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/16529/4/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@1556 PS4, Line 1556: authorize(stmt) : .ok(onServer(TPrivilegeLevel.ALL)) : .ok(onServer(TPrivilegeLevel.OWNER)) : .ok(onServer(TPrivilegeLevel.CREATE), onUri(uri, TPrivilegeLevel.ALL)) : .ok(onServer(TPrivilegeLevel.CREATE), onUri(uri, TPrivilegeLevel.OWNER)) : .error(createError("newdb")) : .error(createError("newdb"), onServer(allExcept(TPrivilegeLevel.ALL, : TPrivilegeLevel.OWNER, TPrivilegeLevel.CREATE)), : onUri(uri, TPrivilegeLevel.ALL)) : .error(createError("newdb"), onServer(allExcept(TPrivilegeLevel.ALL, : TPrivilegeLevel.OWNER, TPrivilegeLevel.CREATE)), : onUri(uri, TPrivilegeLevel.OWNER)) : .error(accessError(uri), onServer(TPrivilegeLevel.CREATE)); nit: instead of copy-pasting this could go to a helper function. http://gerrit.cloudera.org:8080/#/c/16529/4/testdata/workloads/functional-query/queries/QueryTest/describe-hive-db.test File testdata/workloads/functional-query/queries/QueryTest/describe-hive-db.test: http://gerrit.cloudera.org:8080/#/c/16529/4/testdata/workloads/functional-query/queries/QueryTest/describe-hive-db.test@36 PS4, Line 36: 'managedlocation:','$NAMENODE/test2.db','' Instead of putting it in a new row, how about adding it as the last column in the non-extended output? -- To view, visit http://gerrit.cloudera.org:8080/16529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I925632a43ff224f762031e89981896722e453399 Gerrit-Change-Number: 16529 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2020 08:07:44 +0000 Gerrit-HasComments: Yes
