Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16385 )
Change subject: IMPALA-9792: Add ability to split kudu scan ranges ...................................................................... Patch Set 7: Code-Review+2 (2 comments) Fixed test that caused GVO failure earlier. Carrying forward Tim's +2 http://gerrit.cloudera.org:8080/#/c/16385/6/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/16385/6/be/src/service/query-options-test.cc@157 PS6, Line 157: - > Maybe 1KB is the lowest range instead of 0? these are just the values that this variable can hold, for this 0 means disabled and -1 means 'not set' which would eventually use a default value. http://gerrit.cloudera.org:8080/#/c/16385/6/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/16385/6/common/thrift/ImpalaInternalService.thrift@460 PS6, Line 460: ed. > Maybe comment on the unit for the scan range length. Done. Changed in ImpalaService.thrift instead. -- To view, visit http://gerrit.cloudera.org:8080/16385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia02fd94cc1d13c61bc6cb0765dd2cbe90e9a5ce8 Gerrit-Change-Number: 16385 Gerrit-PatchSet: 7 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2020 22:48:37 +0000 Gerrit-HasComments: Yes
