Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16550 )
Change subject: IMPALA-10221: Rename 'iceberg_file_format' to 'iceberg.file_format' as Iceberg table property ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Only a small nit about the commit message, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/16550/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16550/1//COMMIT_MSG@9 PS1, Line 9: g.catalog', nit: in commit message body please keep the lines under 72 chars width. -- To view, visit http://gerrit.cloudera.org:8080/16550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I722303fb765aca0f97a79bd6e4504765d355a623 Gerrit-Change-Number: 16550 Gerrit-PatchSet: 1 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Oct 2020 09:27:47 +0000 Gerrit-HasComments: Yes