Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16567 )

Change subject: IMPALA-9485: Enable file handle cache for EC files
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16567/1/be/src/runtime/io/request-ranges.h
File be/src/runtime/io/request-ranges.h:

http://gerrit.cloudera.org:8080/#/c/16567/1/be/src/runtime/io/request-ranges.h@263
PS1, Line 263:   /// 'file'; the mtime must change when the file changes.
> line has trailing whitespace
Done


http://gerrit.cloudera.org:8080/#/c/16567/1/tests/custom_cluster/test_hdfs_fd_caching.py
File tests/custom_cluster/test_hdfs_fd_caching.py:

http://gerrit.cloudera.org:8080/#/c/16567/1/tests/custom_cluster/test_hdfs_fd_caching.py@21
PS1, Line 21:
> flake8: W291 trailing whitespace
Done


http://gerrit.cloudera.org:8080/#/c/16567/1/tests/custom_cluster/test_hdfs_fd_caching.py@21
PS1, Line 21: from tests.common.skip import SkipIfLocal
> line has trailing whitespace
Done



--
To view, visit http://gerrit.cloudera.org:8080/16567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb455eeed02a229a4559d3972dfdac7df32cdb99
Gerrit-Change-Number: 16567
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Comment-Date: Thu, 08 Oct 2020 23:30:13 +0000
Gerrit-HasComments: Yes

Reply via email to