Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16436 )
Change subject: IMPALA-10113: Add feature flag for incremental metadata updates ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16436/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/16436/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@864 PS3, Line 864: // If this is a HdfsTable, make sure we send deletes for removed partitions. > This change is coupled with the change in addTableToCatalogDeltaHelper() an Sure. Done. http://gerrit.cloudera.org:8080/#/c/16436/3/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/16436/3/tests/custom_cluster/test_local_catalog.py@164 PS3, Line 164: "--enable_incremental_metadata_updates=true") > It's enabled by default. I think we need a test for when enable_incremental Sure. This is the only test that depends on enable_incremental_metadata_updates=true. I manually run CORE tests with enable_incremental_metadata_updates=false by default. Will add some tests to cover enable_incremental_metadata_updates=false. -- To view, visit http://gerrit.cloudera.org:8080/16436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98676fc8ca886f3d9f550f9b96fa6d6bff178ebb Gerrit-Change-Number: 16436 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Sat, 10 Oct 2020 03:38:12 +0000 Gerrit-HasComments: Yes
