Qifan Chen has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/16566 )
Change subject: Parent: c0881655 (IMPALA-10178 Run-time profile shall report skews) Author: Qifan Chen <[email protected]> AuthorDate: 2020-10-08 17:03:22 -0400 Commit: Qifan Chen <[email protected]> CommitDate: 2020-10-10 12:12:24 -0400 ...................................................................... Parent: c0881655 (IMPALA-10178 Run-time profile shall report skews) Author: Qifan Chen <[email protected]> AuthorDate: 2020-10-08 17:03:22 -0400 Commit: Qifan Chen <[email protected]> CommitDate: 2020-10-10 12:12:24 -0400 IMPALA-9754 buffer_pool_limit error message is confusing This fix reworded following two error messages for clarity. 1. "Invalid --buffer_pool_limit value, must be a percentage or positive bytes value or percentage:" 2. "Invalid --buffer_pool_clean_pages_limit value, must be a percentage or positive bytes value or percentage:" The fix also enhanced the code to verify that the JVM max heap size is less than the process memory limit when mem_limit_includes_jvm flag is set to true, and raise a new error message otherwise: "Invalid combination of --mem_limit_includes_jvm and JVM max heap size $0, which must be smaller than process memory limit $1". Testing: 1. Unit testing; 2. Ran Core tests successfully. Change-Id: I15ce1cdcc168163b3f5b21e778f9bf6e6b7730d5 --- M be/src/runtime/exec-env.cc 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/16566/6 -- To view, visit http://gerrit.cloudera.org:8080/16566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I15ce1cdcc168163b3f5b21e778f9bf6e6b7730d5 Gerrit-Change-Number: 16566 Gerrit-PatchSet: 6 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
