Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16392 )
Change subject: IMPALA-10075: Reuse unchanged partition instances ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Thanks for the changes! I only have very minor nits. http://gerrit.cloudera.org:8080/#/c/16392/6/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/16392/6/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@274 PS6, Line 274: with nit: "as" would be better here http://gerrit.cloudera.org:8080/#/c/16392/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/16392/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@937 PS6, Line 937: an nit: a -- To view, visit http://gerrit.cloudera.org:8080/16392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dd645c260d271291021e52fdac4b74924df1170 Gerrit-Change-Number: 16392 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Sun, 11 Oct 2020 20:21:51 +0000 Gerrit-HasComments: Yes
