wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16568 )
Change subject: IMPALA-10159: Supporting ORC file format for Iceberg table ...................................................................... Patch Set 7: > Thanks for taking care of this change! > Sorry for the late comment but could you also add a test for SHOW > CREATE TABLE? tests/metadata/test_show_create_table.py > > Otherwise I'm fine with the patch. Thanks for advice! Already add new test case in ‘show-create-table.test’ -- To view, visit http://gerrit.cloudera.org:8080/16568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib579461aa57348c9893a6d26a003a0d812346c4d Gerrit-Change-Number: 16568 Gerrit-PatchSet: 7 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Mon, 12 Oct 2020 09:24:13 +0000 Gerrit-HasComments: No
