Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )
Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients ...................................................................... Patch Set 1: (1 comment) LGTM aside from one minor thing in the shell http://gerrit.cloudera.org:8080/#/c/16573/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16573/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-10224: Add startup flag not to expose debug web url to clients It looks like one of the calls to print the query link in impala_shell is guarded by "not self.webserver_address" but the other one for retried queries isn't. So I think we need a minor fix for that in the shell too. data += "Retried query link: %s\n"\ % self.imp_client.get_query_link(retried_query_id) -- To view, visit http://gerrit.cloudera.org:8080/16573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc Gerrit-Change-Number: 16573 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 12 Oct 2020 16:54:50 +0000 Gerrit-HasComments: Yes
