Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16593
Change subject: IMPALA-9339: Revise explanation of RowMaterializationTimer ...................................................................... IMPALA-9339: Revise explanation of RowMaterializationTimer Fixed the explanation of RowMaterializationTimer and made a small fix to make it more accurate. RowMaterializationTimer is suppose to represent the amount of time calling GetNext on the fragment exec tree when the query has reached a FINISHED state (e.g. at least one RowBatch is sitting in the plan root sink). I updated the comments for the counter to better reflect that and I excluded some possible lock contention overhead from the timer scope. Added a new counter called QueryResultMaterializationTimer, which tracks the time taken to convert RowBatches to QueryResultSets. Tests: * Ran core tests * Added new tests for QueryResultMaterializationTimer Change-Id: I5667fe579e0f0f0931ce93735b1b652b1beaf36d --- M be/src/exec/blocking-plan-root-sink.cc M be/src/exec/buffered-plan-root-sink.cc M be/src/exec/plan-root-sink.cc M be/src/exec/plan-root-sink.h M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M tests/query_test/test_fetch.py 7 files changed, 73 insertions(+), 37 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/16593/1 -- To view, visit http://gerrit.cloudera.org:8080/16593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5667fe579e0f0f0931ce93735b1b652b1beaf36d Gerrit-Change-Number: 16593 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com>
