Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16591 )
Change subject: IMPALA-10055: Fix DCHECK hit on corrupt ORC file ...................................................................... IMPALA-10055: Fix DCHECK hit on corrupt ORC file Our ORC scanner could hit a DCHECK on corrupt ORC files. In test_scanners_fuzz we randomly modify ORC files, so the this test might hit a DCHECK occasionally. I converted the DCHECK to a parse error. This way the fuzz test won't crash the Impala daemon. Testing: Unfortunately I don't have an ORC file on which we hit the DCHECK. So I manually changed the code to always raise this error and executed the fuzz test to see if it still succeeds. Change-Id: I18d9f56c3c37afd1a4898ee36f8cc2ddb5049972 Reviewed-on: http://gerrit.cloudera.org:8080/16591 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/orc-column-readers.cc 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I18d9f56c3c37afd1a4898ee36f8cc2ddb5049972 Gerrit-Change-Number: 16591 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
