Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16552 )
Change subject: IMPALA-10220: Fix negative value bug in RpcNetworkTime counter. ...................................................................... IMPALA-10220: Fix negative value bug in RpcNetworkTime counter. Total RPC time was incorrectly computed using resp_.receiver_latency_ns() in function EndDataStreamCompleteCb(). This patch fix the bug by replacing it with eos_rsp_.receiver_latency_ns(). This patch also fix logging mistakes in LogSlowRpc() to use its 'resp' parameter instead of 'resp_' field member. Testing: - Manually run data loading query that exhibit the bug for several times and verify that the Min value of RpcNetworkTime counter is always positive after the patch. The query used in testing is insert query to TPC-DS fact table store_sales of scale 10GB in single machine mini cluster. - Add DCHECK to verify that total rpc time is greater than or equal to receiver_latency_ns. - Run and pass core tests. Change-Id: I2a4d65a3e0f88349bd4ee1b01290bd2c386acc69 Reviewed-on: http://gerrit.cloudera.org:8080/16552 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/krpc-data-stream-sender.cc 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16552 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2a4d65a3e0f88349bd4ee1b01290bd2c386acc69 Gerrit-Change-Number: 16552 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
