Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16597 )
Change subject: IMPALA-10127: Fix performance for enforcement of lirs_tombstone_multiple ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16597/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16597/1//COMMIT_MSG@25 PS1, Line 25: a pointer to the front of the unprotected list (i.e. the > I found it a little counterintuitive that the front is the right end of the Yeah, I played around with reversing the diagram, but I kept thinking it looked weird that way. I'm just going to trust future developers to figure it out. http://gerrit.cloudera.org:8080/#/c/16597/1//COMMIT_MSG@38 PS1, Line 38: pathalogical > pathological Done http://gerrit.cloudera.org:8080/#/c/16597/1/be/src/util/cache/lirs-cache.cc File be/src/util/cache/lirs-cache.cc: http://gerrit.cloudera.org:8080/#/c/16597/1/be/src/util/cache/lirs-cache.cc@586 PS1, Line 586: auto it = unprotected_tombstone_list_.begin(); > I found this a bit counter-intuitive because I would've expected begin() to Yeah, the downside of the combined list is that it is complicated, requiring diagrams and whatnot. For some reason, the back = left sticks in my head for queues. I changed the diagram to add begin()/end() and changed the wording slightly. -- To view, visit http://gerrit.cloudera.org:8080/16597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25b697f57c7daacccf8791a5a7b31878a6f7f1d2 Gerrit-Change-Number: 16597 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 14 Oct 2020 22:49:06 +0000 Gerrit-HasComments: Yes
