Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16500 )

Change subject: IMPALA-10198 (part 1): Unify Java in a single java/ directory
......................................................................


Patch Set 8:

The only change since last upload, other than the rebase, is a change to how we 
generate and run tests with the test-hive-udfs jar.

test-hive-udfs is used to generate two jars. One is the regular jar based on 
the normal code. The other is a modified jar where some of the UDFs have been 
modified to return a different value. This is used to test updates to the jars 
with drop/create, etc. It relied on 
test-hive-udfs/target/test-hive-udfs-1.0.jar being the modified version.

test-hive-udfs now hooks into our Java build and we don't leave the 
modifications in place, so we can't guarantee that 
test-hive-udfs/target/test-hive-udfs-1.0.jar is built using the modified code. 
So, this copies that jar to a specific location after building the modified 
version and then uses that location in the tests.


--
To view, visit http://gerrit.cloudera.org:8080/16500
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08773f4f9d7cb269b0491080078d6e6f490d8d7a
Gerrit-Change-Number: 16500
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Thu, 15 Oct 2020 00:35:49 +0000
Gerrit-HasComments: No

Reply via email to