Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16575 )
Change subject: IMPALA-10152: part 1: refactor Iceberg catalog handling ...................................................................... IMPALA-10152: part 1: refactor Iceberg catalog handling This patch refactors the code a bit to make it easier in the future to add support for new Iceberg catalogs. We plan to add support for HiveCatalog in the near future. Iceberg has two main interfaces to manage tables: Tables and Catalog. I created a new interface in Impala called 'IcebergCatalog' that abstracts both Tables and Catalog. Currently there are two implementations for IcebergCatalog: * HadoopTablesCatalog for HadoopTables * HadoopCatalog for HadoopCatalog This patch also delegates dropTable() to the Iceberg catalogs. Until this patch we let HMS drop the tables and delete the directories. It worked fine with the filesystem-based catalogs, but might not work well with other Iceberg catalogs like HiveCatalog. Change-Id: Ie69dff6cd6b8b3dc0ba5f7671b8504a936032a85 Reviewed-on: http://gerrit.cloudera.org:8080/16575 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java A fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java A fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopCatalog.java A fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergHadoopTables.java M fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java M fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/IcebergUtil.java M tests/query_test/test_iceberg.py 13 files changed, 382 insertions(+), 100 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie69dff6cd6b8b3dc0ba5f7671b8504a936032a85 Gerrit-Change-Number: 16575 Gerrit-PatchSet: 9 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]>
