Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16549 )

Change subject: IMPALA-6671: Skip locked tables from topic updates
......................................................................


Patch Set 2:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/16549/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/16549/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1354
PS2, Line 1354:               "Unable to update the pending version of the 
table " + tbl.getFullName(), ex);
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/16549/2/tests/metadata/test_topic_update_frequency.py
File tests/metadata/test_topic_update_frequency.py:

http://gerrit.cloudera.org:8080/#/c/16549/2/tests/metadata/test_topic_update_frequency.py@15
PS2, Line 15: import threading
flake8: F401 'threading' imported but unused


http://gerrit.cloudera.org:8080/#/c/16549/2/tests/metadata/test_topic_update_frequency.py@18
PS2, Line 18: from time import sleep
flake8: F401 'time.sleep' imported but unused


http://gerrit.cloudera.org:8080/#/c/16549/2/tests/metadata/test_topic_update_frequency.py@20
PS2, Line 20: from tests.beeswax.impala_beeswax import ImpalaBeeswaxException
flake8: F401 'tests.beeswax.impala_beeswax.ImpalaBeeswaxException' imported but 
unused


http://gerrit.cloudera.org:8080/#/c/16549/2/tests/metadata/test_topic_update_frequency.py@53
PS2, Line 53: l
flake8: E501 line too long (145 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/16549/2/tests/metadata/test_topic_update_frequency.py@112
PS2, Line 112: l
flake8: E501 line too long (145 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/16549/2/tests/metadata/test_topic_update_frequency.py@177
PS2, Line 177: f
flake8: E126 continuation line over-indented for hanging indent



--
To view, visit http://gerrit.cloudera.org:8080/16549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic657b96edbcdc94c6b906e7ca59291f4e4715655
Gerrit-Change-Number: 16549
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Shant Hovsepian <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Thu, 15 Oct 2020 21:55:04 +0000
Gerrit-HasComments: Yes

Reply via email to