Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16273 )
Change subject: IMPALA-9990: Support SET OWNER for Kudu tables ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16273/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16273/2//COMMIT_MSG@29 PS2, Line 29: Kudu-Python client if the E2E test If you already intend on testing using Kudu's Python bindings, it may also be worth testing the alter owner scenario and verifying that the Kudu's table.owner() matches that in the HMS. That'd be a good regression test for IMPALA-9990. http://gerrit.cloudera.org:8080/#/c/16273/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16273/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@550 PS2, Line 550: is changed to a managed table or an external : // table with the property of 'external.table.purge' being true from an external : // table with 'external.table.purge' not being true immediately before this method. nit: it's fine keeping this as is if it aligns more with Impala parlance, but this could be more succinct as, "if 'table' is changed to a synchronized Kudu table from an external, non-synchronized table before this method is called." -- To view, visit http://gerrit.cloudera.org:8080/16273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29d641efc8db314964bc5ee9828a86d4a44ae95c Gerrit-Change-Number: 16273 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 19 Oct 2020 19:18:23 +0000 Gerrit-HasComments: Yes
