Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16606 )
Change subject: IMPALA-10166 ALTER TABLE for Iceberg tables ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16606/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16606/3//COMMIT_MSG@11 PS3, Line 11: * ADD COLUMNS : * DROP COLUMN : * REPLACE COLUMNS : * ALTER COLUMN CHANGE COLUMN > Thanks Zoltan, it indeed a problem. If you insist supporting for ALTER TABL Yeah, it makes sense to me. I think we cannot support both RENAME and DROP because if those are combined, we cannot find the affected columns by name, neither by position. DROP also interacts weirdly with ADD COLUMN. E.g. DROP + ADD column with the same name is a troublesome edge case. So I think we should add support for DROP after step 2. -- To view, visit http://gerrit.cloudera.org:8080/16606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5104cc47c7b42dacdb52983f503cd263135d6bfc Gerrit-Change-Number: 16606 Gerrit-PatchSet: 3 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 20 Oct 2020 13:17:02 +0000 Gerrit-HasComments: Yes
