Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16621 )
Change subject: IMPALA-3816 Codegen perf critical loops in Sorter ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/16621/4/be/src/runtime/sorter-internal.h File be/src/runtime/sorter-internal.h: http://gerrit.cloudera.org:8080/#/c/16621/4/be/src/runtime/sorter-internal.h@487 PS4, Line 487: Status IR_ALWAYS_INLINE InsertionSort(const TupleIterator& begin, const TupleIterator& end); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/16621/4/be/src/runtime/sorter-ir.cc File be/src/runtime/sorter-ir.cc: http://gerrit.cloudera.org:8080/#/c/16621/4/be/src/runtime/sorter-ir.cc@68 PS4, Line 68: bool IR_ALWAYS_INLINE Sorter::TupleSorter::Less(const TupleRow* lhs, const TupleRow* rhs) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16621/4/be/src/runtime/sorter-ir.cc@188 PS4, Line 188: Tuple* IR_ALWAYS_INLINE Sorter::TupleSorter::SelectPivot(TupleIterator begin, TupleIterator end) { line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/16621/4/be/src/runtime/sorter-ir.cc@212 PS4, Line 212: Tuple* IR_ALWAYS_INLINE Sorter::TupleSorter::MedianOfThree(Tuple* t1, Tuple* t2, Tuple* t3) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/16621/4/be/src/runtime/sorter-ir.cc@249 PS4, Line 249: void IR_ALWAYS_INLINE Sorter::TupleSorter::Swap(Tuple* RESTRICT left, Tuple* RESTRICT right, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie08137449d4a7b554ca8b8650260f8bd72e0a81b Gerrit-Change-Number: 16621 Gerrit-PatchSet: 4 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Oct 2020 18:50:59 +0000 Gerrit-HasComments: Yes
