Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16622 )

Change subject: IMPALA-10252: fix invalid runtime filters for outer joins
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16622/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java:

http://gerrit.cloudera.org:8080/#/c/16622/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@379
PS2, Line 379:             // input then it is not safe to generate a runtime 
filter from a LEFT OUTER JOIN
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/16622/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@382
PS2, Line 382:             // E.g. If the source expression is zeroifnull(y), 
column y has values [1, 2, 3],
line too long (93 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/16622
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I507af1cc8df15bca21e0d8555019997812087261
Gerrit-Change-Number: 16622
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Oct 2020 19:02:29 +0000
Gerrit-HasComments: Yes

Reply via email to