Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16613 )
Change subject: IMPALA-10244: Make non-scalable failures to dequeue observable. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16613/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/16613/2/common/thrift/metrics.json@2731 PS2, Line 2731: Query dequeue failed because of a non-scalable limit > I originally planned to have the name be related to "coordinator" but (else I will change to use the name, suggested by Quigan http://gerrit.cloudera.org:8080/#/c/16613/2/common/thrift/metrics.json@2734 PS2, Line 2734: admission-controller.total-dequeue-failed-cannot-scale" > I had the same impression here as well. The new counter added counts the # Thanks! I will use this name -- To view, visit http://gerrit.cloudera.org:8080/16613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3456396ac139c562ad9cd3ac1a624d8f35487518 Gerrit-Change-Number: 16613 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Oct 2020 21:15:13 +0000 Gerrit-HasComments: Yes
