Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16660 )
Change subject: IMPALA-10234: Add support for cookie authentication to impala-shell ...................................................................... Patch Set 1: (11 comments) http://gerrit.cloudera.org:8080/#/c/16660/1/shell/ImpalaHttpClient.py File shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/16660/1/shell/ImpalaHttpClient.py@214 PS1, Line 214: o flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16660/1/shell/cookie_util.py File shell/cookie_util.py: http://gerrit.cloudera.org:8080/#/c/16660/1/shell/cookie_util.py@25 PS1, Line 25: def cookie_matches_path(c, path): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/16660/1/shell/cookie_util.py@45 PS1, Line 45: e flake8: E722 do not use bare except' http://gerrit.cloudera.org:8080/#/c/16660/1/shell/cookie_util.py@58 PS1, Line 58: e flake8: E722 do not use bare except' http://gerrit.cloudera.org:8080/#/c/16660/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/16660/1/shell/impala_client.py@400 PS1, Line 400: d flake8: E306 expected 1 blank line before a nested definition, found 0 http://gerrit.cloudera.org:8080/#/c/16660/1/shell/impala_client.py@402 PS1, Line 402: flake8: E202 whitespace before ')' http://gerrit.cloudera.org:8080/#/c/16660/1/tests/shell/test_cookie_util.py File tests/shell/test_cookie_util.py: http://gerrit.cloudera.org:8080/#/c/16660/1/tests/shell/test_cookie_util.py@24 PS1, Line 24: o flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16660/1/tests/shell/test_cookie_util.py@74 PS1, Line 74: k flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16660/1/tests/shell/test_cookie_util.py@76 PS1, Line 76: flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16660/1/tests/shell/test_cookie_util.py@79 PS1, Line 79: d flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/16660/1/tests/shell/test_cookie_util.py@123 PS1, Line 123: r flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/16660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb0bc6e0f58f236866ca9913a2e63d97d5148f51 Gerrit-Change-Number: 16660 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 27 Oct 2020 14:56:16 +0000 Gerrit-HasComments: Yes
