Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16606 )
Change subject: IMPALA-10166 (part 1): ALTER TABLE for Iceberg tables ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/16606/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test: http://gerrit.cloudera.org:8080/#/c/16606/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test@117 PS8, Line 117: ALTER TABLE iceberg_test3 RENAME TO iceberg_test3_new; > I can use 'iceberg_test3' to replace 'iceberg_test9', since 'iceberg_test3' Well, not tightly related to this patch but the naming of the tables in this test is not ideal in my opinion. Instead of having a counter in the name they should express something from their characteristics and purpose. e.g. iceberg_table_hadoop_catalog, iceberg_table_partitioned e.g. It's hard to figure out for a later reader what the purpose of e.g. iceberg_test3 was. It's up to you if you decide to rename the ones that are touched by this test or we can create a ticket for refactoring later. -- To view, visit http://gerrit.cloudera.org:8080/16606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5104cc47c7b42dacdb52983f503cd263135d6bfc Gerrit-Change-Number: 16606 Gerrit-PatchSet: 9 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 30 Oct 2020 07:49:08 +0000 Gerrit-HasComments: Yes
