Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16649 )

Change subject: IMPALA-10283: Fix IllegalStateException in applying incremental 
partition updates
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16649/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16649/2//COMMIT_MSG@14
PS2, Line 14: aka
> nit, replacing with "via" makes more sense to me.
Done


http://gerrit.cloudera.org:8080/#/c/16649/2//COMMIT_MSG@28
PS2, Line 28: So one of the coordinator will have a table version
            : that is lower than the latest version in catalogd but larger than 
the
            : last sent table version in catalogd
> IIUC, we are saying that the table in the coordinator cache is already at a
Sorry, not this case. Let's say

last sent catalog version: v1
current catalog version of the table in coordinator: v2
table catalog version in current topic-update: v3

The case is when v1 < v2 < v3, v2 will have some partition instances of v3. So 
when applying partition updates of v3, we will see duplicated partition 
instances. Let me update the commit message with an example.



--
To view, visit http://gerrit.cloudera.org:8080/16649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1657684f8853b76b1524475a3b3c35fa22a0e36e
Gerrit-Change-Number: 16649
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Tue, 03 Nov 2020 01:24:51 +0000
Gerrit-HasComments: Yes

Reply via email to