Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16676 )
Change subject: IMPALA-9355: TestExchangeMemUsage.test_exchange_mem_usage_scaling doesn't hit the memory limit ...................................................................... Patch Set 2: (1 comment) The change looks good from a content point of view. I have one small style point. http://gerrit.cloudera.org:8080/#/c/16676/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test File testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test: http://gerrit.cloudera.org:8080/#/c/16676/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test@7 PS2, Line 7: # IMPALA-9355: TestExchangeMemUsage.test_exchange_mem_usage_scaling doesn't hit : # the memory limit. The mem_limit is reduced from 170MB to 168MB since the memory : # shortage observed at exchange nodes can be as small as 8KB without exceeding : # the limit of 170MB. >From a purely style note, I think this comment is not necessary. The comment >about IMPALA-5485 is describing why this test exists and is useful to a >reader. The details about adjustments to the memory limit to avoid flakiness >are important for the history, but it is usually not something a reader of >this file needs to know about. All the history is accessible by git blame, so >they can find the commit that set the mem_limit=168m if they need. So, I would >lean toward not including a comment for this. -- To view, visit http://gerrit.cloudera.org:8080/16676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c33e3b254ce75054bf6cee0eff8b7206fa0c122 Gerrit-Change-Number: 16676 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 01:30:07 +0000 Gerrit-HasComments: Yes
