Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16645 )
Change subject: IMPALA-10279: Import CPC functionality from DataSketches ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/16645/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16645/6//COMMIT_MSG@11 PS6, Line 11: : First, I updated our existing snapshot of DataSketches to the : following commit:2b84e213067b681b696ec883d245ddf911790ff2 > I checked manually the commits between the git hash we used previously and The previous snapshot(commit:c1a6f8edb49699520f248d3d02019b87429b4241) already contains the first 4 commits, see: https://github.com/apache/incubator-datasketches-cpp/commits/2.1.x-incubating The commit(c5be98a81c5947e5100868b90fb0f50aba4a9334) affects our snapshot files: +41 ?0 {theta ? common}/include/binomial_bounds.hpp +41 ?0 common/include/ceiling_power_of_2.hpp +15 ?0 common/include/common_defs.hpp +6 ?1 {theta ? common}/include/conditional_back_inserter.hpp +70 ?0 common/include/conditional_forward.hpp +15 ?15 common/include/serde.hpp +3 ?15 hll/include/HllUtil.hpp These files have been updated to our snapshot. http://gerrit.cloudera.org:8080/#/c/16645/6/be/src/exprs/datasketches-test.cc File be/src/exprs/datasketches-test.cc: http://gerrit.cloudera.org:8080/#/c/16645/6/be/src/exprs/datasketches-test.cc@114 PS6, Line 114: // Like HLL, the order of the inputs fed to the sketches is fix here so we get the > thx! I just wanted to make sure that this result is deterministic and is th The result is deterministic, comments have been added. http://gerrit.cloudera.org:8080/#/c/16645/7/be/src/thirdparty/datasketches/README.md File be/src/thirdparty/datasketches/README.md: http://gerrit.cloudera.org:8080/#/c/16645/7/be/src/thirdparty/datasketches/README.md@16 PS7, Line 16: https://github.com/apache/incubator-datasketches-cpp/ > Could you provide a link here that points to the particular snapshot that y Done -- To view, visit http://gerrit.cloudera.org:8080/16645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e8d0c2e80df95fa84af82c64d493df9bbb34a8c Gerrit-Change-Number: 16645 Gerrit-PatchSet: 8 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 05 Nov 2020 05:29:00 +0000 Gerrit-HasComments: Yes
