Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16702 )
Change subject: IMPALA-10309: Use sleep time from a Retry-After header in Impala Shell ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16702/3/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/16702/3/shell/impala_client.py@986 PS3, Line 986: print('Caught exception {0}, type={1} in {2}. {3}, retry after {4} secs' For the last try (with no more retries left), we will still have a message "retry after {4} secs" at the end. That could be confusing? We could probably update the condition in L978 so that we have a non None 'retry_secs' for all but the last try. -- To view, visit http://gerrit.cloudera.org:8080/16702 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4226e7723d585d61deb4d1d6777aac901bfd93 Gerrit-Change-Number: 16702 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2020 17:58:16 +0000 Gerrit-HasComments: Yes
