Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: [BE] flag for Kudu connection negotiation timeout ...................................................................... Patch Set 1: > > Build Failed > > > > https://jenkins.impala.io/job/gerrit-code-review-checks/7625/ : > > Initial code review checks failed. See linked job for details on > > the failure. > > Whoops, it seems the version of Kudu client that Impala uses > doesn't include the necessary changes implemented as part of > KUDU-2966: > https://jenkins.impala.io/job/ubuntu-16.04-build-only/12832/console > > I guess I should re-submit this patch after the newly introduced > functionality in Kudu client is released in with Kudu 1.14. > > Anyways, it would be great to get some feedback on this change. > > Thanks! Yeah, you'll need to bump the version of Kudu in native toolchain: https://github.com/cloudera/native-toolchain/blob/master/buildall.sh#L322 Otherwise, this patch looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/16705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466 Gerrit-Change-Number: 16705 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2020 19:47:39 +0000 Gerrit-HasComments: No
