Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/16712 )
Change subject: IMPALA-7876: COMPUTE STATS TABLESAMPLE is not updating number of estimated rows ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16712/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/16712/3/tests/common/impala_test_suite.py@933 PS3, Line 933: # Both a and b must be positive for the following check to make sense. > Hmm, do you think it's easier to just not mess with it then? I think I will fix appx_equals for -ive values like you suggested. And also fix the callers to pass a valid diff_perc. Its only being called in a couple of places so should be okay. Let me make these changes. -- To view, visit http://gerrit.cloudera.org:8080/16712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88a0a777c2be9cc18b3ff293cf1c06fb499ca052 Gerrit-Change-Number: 16712 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 12 Nov 2020 20:05:01 +0000 Gerrit-HasComments: Yes
