Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 )
Change subject: IMPALA-10314: Optimize planning time for simple limits ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@847 PS1, Line 847: (analyzer.getQueryCtx().client_request.getQuery_options() > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1328 PS1, Line 1328: inlineViewRef.getAnalyzer().setSimpleLimitStatus(new Pair<>(new Boolean(true), > line too long (106 > 90) Done http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1564 PS1, Line 1564: if (hdfsTblRef.getSampleParams() == null > line too long (95 > 90) Done http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1581 PS1, Line 1581: } > line too long (96 > 90) Done http://gerrit.cloudera.org:8080/#/c/16723/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1584 PS1, Line 1584: finalPartitions, hdfsTblRef, aggInfo, pair.second, isPartitionKeyScan); > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/16723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d6a79263bc092e0f3e9a1d72da5618f3cc35574 Gerrit-Change-Number: 16723 Gerrit-PatchSet: 2 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 16 Nov 2020 04:33:07 +0000 Gerrit-HasComments: Yes
