Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 )
Change subject: [WIP] IMPALA-10325 Parquet scan should use min/max statistics to skip pages based on equi-join predicate ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/16720/3/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/16720/3/be/src/exec/hdfs-scan-node.cc@377 PS3, Line 377: VLOG(1) << "HdfsScanNode::ScannerThread(): filter_ctx_" line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16720/3/be/src/exec/hdfs-scan-node.cc@378 PS3, Line 378: << ", size=" << filter_ctxs_.size(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16720/3/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/16720/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@755 PS3, Line 755: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16720/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@766 PS3, Line 766: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16720/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@808 PS3, Line 808: VLOG(1) << "For predicate " << root.DebugString() line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16720/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@863 PS3, Line 863: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16720/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@866 PS3, Line 866: // Pull in the min and max of the page at slot line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16720/3/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/16720/3/common/thrift/PlanNodes.thrift@299 PS3, Line 299: 12: optional list<i32> slot_usage_map line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/16720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I379405ee75b14929df7d6b5d20dabc6f51375691 Gerrit-Change-Number: 16720 Gerrit-PatchSet: 3 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 17 Nov 2020 23:46:56 +0000 Gerrit-HasComments: Yes
