Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16739 )
Change subject: IMPALA-10276: thread-safe access to RuntimeProfile::counter_map_ ...................................................................... IMPALA-10276: thread-safe access to RuntimeProfile::counter_map_ The bug was that 'counter_map_' can be mutated concurrent with total_time_counter() or inactive_timer() being called. This is fixed by storing a pointer directly to those counters and bypassing 'counter_map_'. This is then thread-safe and also has low overhead (adding lock acquisitions might have some perf impact, since total_time_counter() is called throughout query execution). Change-Id: Ic21a13acf9c7c326a27334e61ce3729f1e3cab42 Reviewed-on: http://gerrit.cloudera.org:8080/16739 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/runtime-profile.cc M be/src/util/runtime-profile.h 2 files changed, 34 insertions(+), 34 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic21a13acf9c7c326a27334e61ce3729f1e3cab42 Gerrit-Change-Number: 16739 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
