Thomas Tauber-Marshall has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16829


Change subject: IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok
......................................................................

IMPALA-10381: Fix overloading of --ldap_passwords_in_clear_ok

The --ldap_passwords_in_clear_ok flag was originally intended to allow
configurations where Impala connects to LDAP without SSL, for testing
purposes.

Since then, two other uses of the flag have been added: 1) for
controlling whether cookies include the 'Secure' attribute and 2) for
controlling whether the webserver allows LDAP auth to be enabled if
SSL isn't.

Some use cases may prefer to control these values separately, so this
patch separates them into three different flags.

Testing:
- Updated existing tests that use --ldap_passwords_in_clear_ok

Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83
---
M be/src/rpc/authentication-util.cc
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
M fe/src/test/java/org/apache/impala/customcluster/LdapJdbcTest.java
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
5 files changed, 17 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/16829/1
--
To view, visit http://gerrit.cloudera.org:8080/16829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12ee3a857365c0fca261a8b06de2321ed6b40a83
Gerrit-Change-Number: 16829
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>

Reply via email to