Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16837 )

Change subject: IMPALA-10211 (Part 1): Add support for role-related statements
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/16837/1/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:

http://gerrit.cloudera.org:8080/#/c/16837/1/bin/create-test-configuration.sh@248
PS1, Line 248:                 <intercept-url 
pattern="/service/public/v2/api/roles/*" access="permitAll"/> \
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/16837/1/bin/create-test-configuration.sh@249
PS1, Line 249:                 <intercept-url 
pattern="/service/public/v2/api/roles/name/*" access="permitAll"/> \
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/16837/1/bin/create-test-configuration.sh@250
PS1, Line 250:                 <intercept-url 
pattern="/service/public/v2/api/roles/grant/*" access="permitAll"/> \
line too long (100 > 90)


http://gerrit.cloudera.org:8080/#/c/16837/1/bin/create-test-configuration.sh@251
PS1, Line 251:                 <intercept-url 
pattern="/service/public/v2/api/roles/revoke/*" access="permitAll"/> \
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/16837/1/bin/create-test-configuration.sh@252
PS1, Line 252:                 <intercept-url 
pattern="/service/public/v2/api/roles/names/*" access="permitAll"/>' \
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/16837/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
File 
fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java:

http://gerrit.cloudera.org:8080/#/c/16837/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@149
PS1, Line 149:           "Ranger error message: HTTP 400 Error: User doesn't 
have permissions to grant " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/16837/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
File 
fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java:

http://gerrit.cloudera.org:8080/#/c/16837/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@151
PS1, Line 151:         LOG.error("Error executing SHOW ROLE GRANT GROUP " + 
params.getGrant_group() + ".");
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/16837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b204e62a1d8ae1932d955b4efc28be22202860
Gerrit-Change-Number: 16837
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 09 Dec 2020 01:05:13 +0000
Gerrit-HasComments: Yes

Reply via email to