Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16792 )
Change subject: IMPALA-10360: Allow simple limit to be treated as sampling hint ...................................................................... Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16792/7/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/16792/7/fe/src/main/java/org/apache/impala/analysis/TableRef.java@268 PS7, Line 268: public boolean hasConvertLimitToSampleHint() { > line too long (97 > 90) Done http://gerrit.cloudera.org:8080/#/c/16792/7/fe/src/main/java/org/apache/impala/analysis/TableRef.java@269 PS7, Line 269: return convertLimitToSampleHintPercent_ != -1; > line too long (94 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/16792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife05a5343c913006f7659949b327b63d3f10c04b Gerrit-Change-Number: 16792 Gerrit-PatchSet: 8 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Shant Hovsepian <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 09 Dec 2020 07:11:11 +0000 Gerrit-HasComments: Yes
