Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 )
Change subject: IMPALA-10377 Improve the accuracy of resource estimation PlanNode does not consider some factors when estimating memory, this will cause a large error rate ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16842/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/16842/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@546 PS2, Line 546: perInstanceInputCardinality = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/16842/2/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java File fe/src/test/java/org/apache/impala/planner/CardinalityTest.java: http://gerrit.cloudera.org:8080/#/c/16842/2/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@894 PS2, Line 894: "FUNCTIONAL.ALLTYPES A1,FUNCTIONAL.ALLTYPES B1 GROUP BY A1.ID,B1.DATE_STRING_COL) " + line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic01db168ff2c6d6de33ee553a8175599f035d7a1 Gerrit-Change-Number: 16842 Gerrit-PatchSet: 2 Gerrit-Owner: liuyao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 10 Dec 2020 05:35:12 +0000 Gerrit-HasComments: Yes
