Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16855 )
Change subject: IMPALA-10390: impala-profile-tool JSON output ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16855/2/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/16855/2/be/src/util/impala-profile-tool.cc@44 PS2, Line 44: " json: output as JSON with one profile per line\n" > missing description for prettyjson option? Done http://gerrit.cloudera.org:8080/#/c/16855/2/be/src/util/impala-profile-tool.cc@120 PS2, Line 120: CHECK_EQ("json", profile_format); > For json and prettyjson format, what if we return array of json profile? The one line per document is pretty common and is a bit easier to handle with command line tools - I discovered there's even a website https://jsonlines.org/ I take your point for the pretty-printed version - it is hard to parse apart the profiles with them split across lines, so I did convert that into an array representation. -- To view, visit http://gerrit.cloudera.org:8080/16855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82ae0fe9379b7e3cbe93166adaa4c37212ea0f67 Gerrit-Change-Number: 16855 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 11 Dec 2020 01:29:38 +0000 Gerrit-HasComments: Yes
