Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16835 )
Change subject: IMPALA-10383: Fix data race on AdmissionController::queue_nodes_ ...................................................................... IMPALA-10383: Fix data race on AdmissionController::queue_nodes_ IMPALA-9930 introduces a new data structure to AdmissionController: 'queue_nodes_'. The intention was that access to 'queue_nodes_' should always be protected by 'queue_nodes_lock_', but this was not always the case. This patch fixes the issue by ensuring that 'queue_nodes_lock_' is held everywhere that 'queue_nodes_' is used. Testing: - Ran TSAN and confirmed there is no longer a data race being reported. Change-Id: I05b70112300d3a886bdd5f02fda0bd7ca98df6cf Reviewed-on: http://gerrit.cloudera.org:8080/16835 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/scheduling/admission-controller.cc 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I05b70112300d3a886bdd5f02fda0bd7ca98df6cf Gerrit-Change-Number: 16835 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
