Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16856 )
Change subject: IMPALA-10375: Lock down which filesystems use the file handle cache ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16856/1/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/16856/1/be/src/runtime/io/scan-range.cc@200 PS1, Line 200: if (is_file_handle_caching_enabled() && filesystem_supports_handle_caching(file()) && > I was originally thinking about this from the point of view of performance Yeah, it seems like the bare minimum would be to detect the filesystem type prior to AssignQueue() and pass it into that as an enum. Then AssignQueue() wouldn't need the filename, and the same enum can be passed into ScanRange::Reset() which can be used for this. I will look into passing it from the Frontend, and at the least do the above. -- To view, visit http://gerrit.cloudera.org:8080/16856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136c3da9d19590cdbe8623d22480b8dd07192ce3 Gerrit-Change-Number: 16856 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 11 Dec 2020 18:32:45 +0000 Gerrit-HasComments: Yes
