Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16857 )
Change subject: IMPALA-10391: Fix LIRS edge case for single unprotected entry ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16857/1/be/src/util/cache/lirs-cache.cc File be/src/util/cache/lirs-cache.cc: http://gerrit.cloudera.org:8080/#/c/16857/1/be/src/util/cache/lirs-cache.cc@916 PS1, Line 916: if (num_unprotected_ != 1) { > I guess it's impossible that num_unprotected_ is 0? Maybe add a DCHECK to a Yes, num_unprotected_ must be > 0 in this case. Added a DCHECK here. -- To view, visit http://gerrit.cloudera.org:8080/16857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d21b619811a1a7baab1a92790f2ffc03e949131 Gerrit-Change-Number: 16857 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 14 Dec 2020 21:02:52 +0000 Gerrit-HasComments: Yes
