Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16873 )
Change subject: IMPALA-10393: Iceberg field id-based column resolution fails in ASAN builds ...................................................................... IMPALA-10393: Iceberg field id-based column resolution fails in ASAN builds For MAP types field id resolution indexes the top-level columns via the current 'table_idx - 1'. In this case table_idx is either SchemaPathConstants::MAP_KEY or SchemaPathConstants::MAP_VALUE which are 0 and 1 respectively. Hence 'table_idx - 1' can be -1 which is not a valid index for a vector, hence we get an ASAN error. Even if 'table_idx - 1' is zero we get a wrong field id. Note that at this point in the schema resolution we have successfully found a MAP type with a matching field id, therefore it is safe to resolve the child via the value of 'table_idx' (which is the position of the child, MAP_KEY or MAP_VALUE). Testing: * Built impala with ASAN (buildall.sh -notests -skiptests -asan), then executed test_iceberg_query Change-Id: I41e8daaebe8a6024716e6c22f6ccd819f43508bd Reviewed-on: http://gerrit.cloudera.org:8080/16873 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/parquet/parquet-metadata-utils.cc M tests/query_test/test_scanners.py 2 files changed, 3 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I41e8daaebe8a6024716e6c22f6ccd819f43508bd Gerrit-Change-Number: 16873 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]>
