Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 )
Change subject: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/16741/13/be/src/exprs/iceberg-functions-ir.cc File be/src/exprs/iceberg-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/16741/13/be/src/exprs/iceberg-functions-ir.cc@144 PS13, Line 144: std::string buffer; > Maybe we can avoid dynamic memory allocations if we just used std::string a Done http://gerrit.cloudera.org:8080/#/c/16741/13/be/src/util/bit-util.h File be/src/util/bit-util.h: http://gerrit.cloudera.org:8080/#/c/16741/13/be/src/util/bit-util.h@355 PS13, Line 355: . -1 > Maybe we could just return the vector. I wanted to avoid copy-ing the vector, but sure, I can return it as a return value as well. Done. http://gerrit.cloudera.org:8080/#/c/16741/12/be/src/util/bit-util.h File be/src/util/bit-util.h: http://gerrit.cloudera.org:8080/#/c/16741/12/be/src/util/bit-util.h@357 PS12, Line 357: static std::string IntToByteBuff > I think we don't need the negation at L357 and the multiplication with -1 a Nice solution! I'll use this one. -- To view, visit http://gerrit.cloudera.org:8080/16741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I485680cf79d96d578dd8cfbfd554bec468fe84bd Gerrit-Change-Number: 16741 Gerrit-PatchSet: 14 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 16 Dec 2020 16:46:35 +0000 Gerrit-HasComments: Yes
