Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16837 )
Change subject: IMPALA-10211 (Part 1): Add support for role-related statements ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/16837/10/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/16837/10/tests/authorization/test_ranger.py@534 PS10, Line 534: # TODO(IMPALA-10399): We found that if this test is run after : # test_grant_revoke_with_role() in the exhaustive tests, the test could fail due to an : # empty list returned from the first call to _get_ranger_privileges_db() although a : # list consisting of "lock" and "select" is expected. We suspect there might be : # something wrong with the underlying Ranger API but it requires more thorough : # investigation. Does this mean after this patch, the exhaustive builds will always fail? I try running these two tests but can't reproduce the failure locally. Maybe there are some other reasons. It'd be good if we can keep exhaustive builds green. For how to trigger these two tests in a run, we need to modify the last line of bin/impala-py.test as -exec "$PY_ENV_DIR/bin/py.test" "$@" +exec "$PY_ENV_DIR/bin/py.test" $@ i.e. removing the double quotes of $@. Then trigger the two tests in a one-line command: bin/impala-py.test tests/authorization/test_ranger.py::TestRanger::test_grant_revoke_with_role tests/authorization/test_ranger.py::TestRanger::test_show_grant_hive_privilege They both passed in my local env in the order you mentioned: platform linux2 -- Python 2.7.16, pytest-2.9.2, py-1.4.32, pluggy-0.3.1 -- /home/quanlong/workspace/Impala/infra/python/env-gcc7.5.0/bin/python cachedir: tests/.cache rootdir: /home/quanlong/workspace/Impala/tests, inifile: pytest.ini plugins: xdist-1.17.1, timeout-1.2.1, random-0.2, forked-0.2 timeout: 7200s method: signal collected 30 items tests/authorization/test_ranger.py::TestRanger::test_grant_revoke_with_role[protocol: beeswax | exec_option: {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | table_format: text/none] PASSED tests/authorization/test_ranger.py::TestRanger::test_show_grant_hive_privilege PASSED -- To view, visit http://gerrit.cloudera.org:8080/16837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2b204e62a1d8ae1932d955b4efc28be22202860 Gerrit-Change-Number: 16837 Gerrit-PatchSet: 10 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 20 Dec 2020 10:17:49 +0000 Gerrit-HasComments: Yes
