Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16891 )

Change subject: IMPALA-9975 (part 2): Introduce new admission control daemon
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/16891/1/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:

http://gerrit.cloudera.org:8080/#/c/16891/1/bin/start-impala-cluster.py@74
PS1, Line 74: t
flake8: E501 line too long (98 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/16891/1/bin/start-impala-cluster.py@293
PS1, Line 293: def build_admissiond_arg_list():
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/16891/1/tests/common/impala_cluster.py
File tests/common/impala_cluster.py:

http://gerrit.cloudera.org:8080/#/c/16891/1/tests/common/impala_cluster.py@106
PS1, Line 106: s
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/16891/1/tests/common/impala_cluster.py@236
PS1, Line 236: i
flake8: E501 line too long (101 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/16891/1/tests/common/impala_cluster.py@566
PS1, Line 566: class AdmissiondProcess(BaseImpalaProcess):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/16891/1/tests/common/impala_cluster.py@571
PS1, Line 571: #
flake8: E265 block comment should start with '# '



--
To view, visit http://gerrit.cloudera.org:8080/16891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id677814b31e9193035e8cf0d08aba0ce388a0ad9
Gerrit-Change-Number: 16891
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Mon, 21 Dec 2020 19:32:21 +0000
Gerrit-HasComments: Yes

Reply via email to